Skip to content

DNSResolver GA Release 2025-05-01 #27780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jamesvoongms
Copy link
Member

@jamesvoongms jamesvoongms commented May 16, 2025

Description

The PR adds the new generation of the api-spec version 2025-05-01, the new version introduces three new major changes

  1. New POST api for a Domain List resource that allows a user to specify a storage URL to supply domains to their domain list rather than inline
  2. Removes blockresponsecode from the DNS Security Rule action type
  3. Removes domains requirement from domain lists as the domains may now come from the bulk request.

Previous PR for generation of 2023-07-01-preview version: #26452

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@jamesvoongms
Copy link
Member Author

Hi team, when I last made changes in november of 2024, the target branch was to be generation but it does not look like that branch exists anymore? Can I get a confirmation if the correct target is now main?

@msJinLei
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor

msJinLei commented May 20, 2025

Hi team, when I last made changes in november of 2024, the target branch was to be generation but it does not look like that branch exists anymore? Can I get a confirmation if the correct target is now main?

yes we have the new process for code-gen modules. Please refer to https://eng.ms/docs/cloud-ai-platform/azure-core/azure-experiences-and-ecosystems/azure-portal-and-client-tools-ruhim/azure-cli-tools-azure-cli-powershell-and-terraform/azure-cli-tools/onboarding/azurepowershell/dev_guidance_codegen

Please commit all required files such as "generate-info.json"

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@msJinLei
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor

msJinLei commented May 21, 2025

The breaking changes caused by API upgrading

  "Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "Az.DnsResolver","Get-AzDnsResolverPolicyDnsSecurityRule","Get-AzDnsResolverPolicyDnsSecurityRule","0","3010","The property 'ActionBlockResponseCode' of type 'Microsoft.Azure.PowerShell.Cmdlets.DnsResolver.Models.Api20230701Preview.IDnsSecurityRule' has been removed.","Add the property 'ActionBlockResponseCode' back to type 'Microsoft.Azure.PowerShell.Cmdlets.DnsResolver.Models.Api20230701Preview.IDnsSecurityRule'."
  "Az.DnsResolver","New-AzDnsResolverPolicyDnsSecurityRule","New-AzDnsResolverPolicyDnsSecurityRule","0","3010","The property 'ActionBlockResponseCode' of type 'Microsoft.Azure.PowerShell.Cmdlets.DnsResolver.Models.Api20230701Preview.IDnsSecurityRule' has been removed.","Add the property 'ActionBlockResponseCode' back to type 'Microsoft.Azure.PowerShell.Cmdlets.DnsResolver.Models.Api20230701Preview.IDnsSecurityRule'."
  "Az.DnsResolver","New-AzDnsResolverPolicyDnsSecurityRule","New-AzDnsResolverPolicyDnsSecurityRule","0","2000","The cmdlet 'New-AzDnsResolverPolicyDnsSecurityRule' no longer supports the parameter 'ActionBlockResponseCode' and no alias was found for the original parameter name.","Add the parameter 'ActionBlockResponseCode' back to the cmdlet 'New-AzDnsResolverPolicyDnsSecurityRule', or add an alias to the original parameter name."
  "Az.DnsResolver","New-AzDnsResolverPolicyDnsSecurityRule","New-AzDnsResolverPolicyDnsSecurityRule","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzDnsResolverPolicyDnsSecurityRule' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzDnsResolverPolicyDnsSecurityRule'."
  "Az.DnsResolver","Update-AzDnsResolverPolicyDnsSecurityRule","Update-AzDnsResolverPolicyDnsSecurityRule","0","3010","The property 'ActionBlockResponseCode' of type 'Microsoft.Azure.PowerShell.Cmdlets.DnsResolver.Models.Api20230701Preview.IDnsSecurityRule' has been removed.","Add the property 'ActionBlockResponseCode' back to type 'Microsoft.Azure.PowerShell.Cmdlets.DnsResolver.Models.Api20230701Preview.IDnsSecurityRule'."
  "Az.DnsResolver","Update-AzDnsResolverPolicyDnsSecurityRule","Update-AzDnsResolverPolicyDnsSecurityRule","0","2000","The cmdlet 'Update-AzDnsResolverPolicyDnsSecurityRule' no longer supports the parameter 'ActionBlockResponseCode' and no alias was found for the original parameter name.","Add the parameter 'ActionBlockResponseCode' back to the cmdlet 'Update-AzDnsResolverPolicyDnsSecurityRule', or add an alias to the original parameter name."
  "Az.DnsResolver","Update-AzDnsResolverPolicyDnsSecurityRule","Update-AzDnsResolverPolicyDnsSecurityRule","0","1050","The parameter set 'UpdateExpanded' for cmdlet 'Update-AzDnsResolverPolicyDnsSecurityRule' has been removed.","Add parameter set 'UpdateExpanded' back to cmdlet 'Update-AzDnsResolverPolicyDnsSecurityRule'."
  "Az.DnsResolver","Update-AzDnsResolverPolicyDnsSecurityRule","Update-AzDnsResolverPolicyDnsSecurityRule","0","1050","The parameter set 'UpdateViaIdentityExpanded' for cmdlet 'Update-AzDnsResolverPolicyDnsSecurityRule' has been removed.","Add parameter set 'UpdateViaIdentityExpanded' back to cmdlet 'Update-AzDnsResolverPolicyDnsSecurityRule'."
  "Az.DnsResolver","Update-AzDnsResolverPolicyDnsSecurityRule","Update-AzDnsResolverPolicyDnsSecurityRule","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Update-AzDnsResolverPolicyDnsSecurityRule' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Update-AzDnsResolverPolicyDnsSecurityRule'."

You can do the customization to avoid breaking change https://github.com/Azure/autorest.powershell/blob/main/docs/customization.md

For failed test cases, please re-record all test cases.

@jamesvoongms jamesvoongms added this to the Az 14.1.0 (06/03/2025) milestone May 21, 2025
@msJinLei msJinLei added the Legacy based on legacy branch (main/generation branch) prior to non-generation migration label May 22, 2025
Copy link

To improve dev experience and reduce maintenance efforts, we are deprecating branch: generation now. Azure-PowerShell modules generated by autorest.powershell no longer target branch generation, and will be targeting directly to main instead.

Please find migration guide and document below:

@msJinLei
Copy link
Contributor

@jamesvoongms please refer to the document above. May be helpful to you

@jamesvoongms
Copy link
Member Author

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 27780 in repo Azure/azure-powershell

@jamesvoongms jamesvoongms force-pushed the release-dnsresolver-ga-2025-05-01 branch from b9972d9 to cc994bc Compare May 22, 2025 21:59
@jamesvoongms
Copy link
Member Author

@msJinLei , is it possible for me to get permissions to run the /azp run?

@msJinLei
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor

  "Module","Cmdlet","Example","Line","RuleName","ProblemId","Severity","Description","Extent","Remediation"
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","st=2025-05-16T03:54:40Z is not a valid command name.","st=2025-05-16T03:54:40Z","Check the spell of st=2025-05-16T03:54:40Z."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","se=2025-05-16T11:54:40Z is not a valid command name.","se=2025-05-16T11:54:40Z","Check the spell of se=2025-05-16T11:54:40Z."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","spr=https is not a valid command name.","spr=https","Check the spell of spr=https."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","sv=2024-11-04 is not a valid command name.","sv=2024-11-04","Check the spell of sv=2024-11-04."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","sr=b is not a valid command name.","sr=b","Check the spell of sr=b."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","sig= is not a valid command name.","sig={exampleSasToken}","Check the spell of sig=."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","exampleSasToken is not a valid command name.","exampleSasToken","Check the spell of exampleSasToken."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","st=2025-05-16T03:54:40Z is not a valid command name.","st=2025-05-16T03:54:40Z","Check the spell of st=2025-05-16T03:54:40Z."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","se=2025-05-16T11:54:40Z is not a valid command name.","se=2025-05-16T11:54:40Z","Check the spell of se=2025-05-16T11:54:40Z."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","spr=https is not a valid command name.","spr=https","Check the spell of spr=https."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","sv=2024-11-04 is not a valid command name.","sv=2024-11-04","Check the spell of sv=2024-11-04."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","sr=b is not a valid command name.","sr=b","Check the spell of sr=b."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","sig= is not a valid command name.","sig={exampleSasToken}","Check the spell of sig=."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","exampleSasToken is not a valid command name.","exampleSasToken","Check the spell of exampleSasToken."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","st=2025-05-16T03:54:40Z is not a valid command name.","st=2025-05-16T03:54:40Z","Check the spell of st=2025-05-16T03:54:40Z."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","se=2025-05-16T11:54:40Z is not a valid command name.","se=2025-05-16T11:54:40Z","Check the spell of se=2025-05-16T11:54:40Z."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","spr=https is not a valid command name.","spr=https","Check the spell of spr=https."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","sv=2024-11-04 is not a valid command name.","sv=2024-11-04","Check the spell of sv=2024-11-04."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","sr=b is not a valid command name.","sr=b","Check the spell of sr=b."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","sig= is not a valid command name.","sig={exampleSasToken}","Check the spell of sig=."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","1","1","Invalid_Cmdlet","5000","1","exampleSasToken is not a valid command name.","exampleSasToken","Check the spell of exampleSasToken."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","st=2025-05-16T03:54:40Z is not a valid command name.","st=2025-05-16T03:54:40Z","Check the spell of st=2025-05-16T03:54:40Z."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","se=2025-05-16T11:54:40Z is not a valid command name.","se=2025-05-16T11:54:40Z","Check the spell of se=2025-05-16T11:54:40Z."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","spr=https is not a valid command name.","spr=https","Check the spell of spr=https."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","sv=2024-11-04 is not a valid command name.","sv=2024-11-04","Check the spell of sv=2024-11-04."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","sr=b is not a valid command name.","sr=b","Check the spell of sr=b."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","sig= is not a valid command name.","sig={exampleSasToken}","Check the spell of sig=."
  "Az.DnsResolver","Invoke-AzDnsResolverBulkDnsResolverDomainList","2","1","Invalid_Cmdlet","5000","1","exampleSasToken is not a valid command name.","exampleSasToken","Check the spell of exampleSasToken."

Invoke-AzDnsResolverBulkDnsResolverDomainList's example has few issues above. Please fix it

@msJinLei
Copy link
Contributor

msJinLei commented May 23, 2025

Your breaking change is that ActionBlockResponseCode is removed from swagger.
The affected cmdlets are Get-AzDnsResolverPolicyDnsSecurityRule, New-AzDnsResolverPolicyDnsSecurityRule and Update-AzDnsResolverPolicyDnsSecurityRule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Legacy based on legacy branch (main/generation branch) prior to non-generation migration needs-revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants